Skip to content

Commit 91d342b

Browse files
committed
Update on "[Executorch][custom ops] Change lib loading logic to account for package dir"
Just looking at the location of the source file. In this case custom_ops.py, can, and does, yield to wrong location depending on where you import custom_ops from. If you are importing custom_ops from another source file inside extension folder, e.g. builder.py that is in extensions/llm/export, then, I think, custom_ops gets resolved to the one installed in site-packages or pip package. But if this is imported from say examples/models/llama/source_transformations/quantized_kv_cache.py (Like in the in next PR), then it seems to resolve to the source location. In one of the CI this is /pytorch/executorch. Now depending on which directory your filepath resolves to, you will search for lib in that. This of course does not work when filepath resolves to source location. This PR changes that to resolve to package location. Differential Revision: [D66385480](https://our.internmc.facebook.com/intern/diff/D66385480/) [ghstack-poisoned]
2 parents 42764ed + 9d4e4db commit 91d342b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

extension/llm/custom_ops/custom_ops.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
logging.info(f"Looking for libcustom_ops_aot_lib.so in {executorch_package_path }")
3232
libs = list(
3333
glob.glob(
34-
f"{executorch_package_path}/**/libquantized_ops_aot_lib.*", recursive=True
34+
f"{executorch_package_path}/**/libcustom_ops_aot_lib.*", recursive=True
3535
)
3636
)
3737
assert len(libs) == 1, f"Expected 1 library but got {len(libs)}"

0 commit comments

Comments
 (0)