Fix pybinding build. (#4243)

shoumikhin · facebook-github-bot · commit 9221ab65856d · 2024-07-12T14:39:08.000-07:00
Summary: Pull Request resolved: #4243 . Reviewed By: larryliu0820 Differential Revision: D59693205 fbshipit-source-id: 0c048185329f54f44af9730eddb53e45ef21873e
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -485,7 +485,7 @@ if(MAX_KERNEL_NUM)
   )
 endif()
 
-if(EXECUTORCH_BUILD_PYBIND)
+if(EXECUTORCH_BUILD_PYBIND AND APPLE)
   # shared version
   add_library(
     executorch_no_prim_ops_shared SHARED ${_executorch_no_prim_ops__srcs}
diff --git a/build/Codegen.cmake b/build/Codegen.cmake
@@ -150,7 +150,7 @@ function(gen_custom_ops_aot_lib)
   include(${EXECUTORCH_ROOT}/build/Utils.cmake)
 
   target_link_options_shared_lib(${GEN_LIB_NAME})
-  if(EXECUTORCH_BUILD_PYBIND)
+  if(EXECUTORCH_BUILD_PYBIND AND APPLE)
     target_link_libraries(${GEN_LIB_NAME} PRIVATE executorch_no_prim_ops_shared)
     target_link_options(${GEN_LIB_NAME} PRIVATE -undefined dynamic_lookup)
   else()

Original file line number	Diff line number	Diff line change
`@@ -485,7 +485,7 @@ if(MAX_KERNEL_NUM)`
`485`	`485`	`)`
`486`	`486`	`endif()`
`487`	`487`
`488`		`-if(EXECUTORCH_BUILD_PYBIND)`
	`488`	`+if(EXECUTORCH_BUILD_PYBIND AND APPLE)`
`489`	`489`	`# shared version`
`490`	`490`	`add_library(`
`491`	`491`	`executorch_no_prim_ops_shared SHARED ${_executorch_no_prim_ops__srcs}`