Skip to content

Commit a06cc40

Browse files
committed
Restore the TODO comment
1 parent 9b1cc94 commit a06cc40

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

.ci/scripts/setup-macos.sh

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,16 @@ install_buck() {
2828
fi
2929

3030
pushd .ci/docker
31+
# TODO(huydo): This is a one-off copy of buck2 2024-05-15 to unblock Jon and
32+
# re-enable ShipIt. It’s not ideal that upgrading buck2 will require a manual
33+
# update the cached binary on S3 bucket too. Let me figure out if there is a
34+
# way to correctly implement the previous setup of installing a new version of
35+
# buck2 only when it’s needed. AFAIK, the complicated part was that buck2
36+
# --version doesn't say anything w.r.t its release version, i.e. 2024-05-15.
37+
# See D53878006 for more details.
38+
#
39+
# If you need to upgrade buck2 version on S3, please reach out to Dev Infra
40+
# team for help.
3141
BUCK2_VERSION=$(cat ci_commit_pins/buck2.txt)
3242
BUCK2=buck2-aarch64-apple-darwin-${BUCK2_VERSION}.zst
3343
curl -s "https://ossci-macos.s3.amazonaws.com/${BUCK2}" -o "${BUCK2}"

0 commit comments

Comments
 (0)