Skip to content

Commit a08a3ec

Browse files
committed
Update on "[ET-VK] Simplifying conv1d op shader by changing it to process one output texel per thread."
This diff changes conv1d shader to process one output texel per thread, increasing GPU occupancy and improve performance. Differential Revision: [D74097560](https://our.internmc.facebook.com/intern/diff/D74097560/) [ghstack-poisoned]
2 parents c5c8ebb + c058837 commit a08a3ec

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

backends/vulkan/runtime/graph/ops/impl/Convolution.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,8 @@ void add_conv1d_node(
512512
const int32_t padding_size = graph.get_int_list(padding)->at(0);
513513
const int32_t dilation_size = graph.get_int_list(dilation)->at(0);
514514
const int32_t in_group_size = static_cast<int64_t>(in_channels / groups_val);
515-
const int32_t out_group_size = static_cast<int64_t>(out_channels / groups_val);
515+
const int32_t out_group_size =
516+
static_cast<int64_t>(out_channels / groups_val);
516517

517518
const utils::uvec3 global_size = {
518519
// out length

0 commit comments

Comments
 (0)