Skip to content

Commit a0eb272

Browse files
committed
Update on "[ET-VK] Fixing out_limits_scaled calculation for conv2d pw ops."
The fix changing the calculation of `out_limits_scaled` from: ```glsl const int out_limits_scaled[2] = {out_limits.x + (TILE_SIZE_X - 1) * TILE_SIZE_X, out_limits.y + (TILE_SIZE_Y - 1) * TILE_SIZE_Y}; ``` to: ```glsl const int out_limits_scaled[2] = {(out_limits.x + (TILE_SIZE_X - 1)) / TILE_SIZE_X, (out_limits.y + (TILE_SIZE_Y - 1)) / TILE_SIZE_Y}; ``` This change ensures that `out_limits_scaled` is calculated correctly, taking into account the tile size and the output limits of the convolution operation. Differential Revision: [D75575662](https://our.internmc.facebook.com/intern/diff/D75575662/) [ghstack-poisoned]
2 parents 4792e66 + d7a5864 commit a0eb272

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

backends/vulkan/vulkan_preprocess.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,14 +150,14 @@ def preprocess( # noqa: C901
150150
program = apply_passes(
151151
program,
152152
[
153+
RemoveRedundantOpsTransform(),
153154
AddmmToLinearTransform(),
154155
FuseQuantizedOpsTransform(program),
155156
SqueezeUnsqueezeInputs(),
156157
FuseViewCopyTransform(),
157158
ViewCopyToSqueezeUnsqueezePass(),
158159
FuseBatchNormWithConvPass(program),
159160
FuseClampPass(),
160-
RemoveRedundantOpsTransform(),
161161
],
162162
)
163163

0 commit comments

Comments
 (0)