Skip to content

Commit a5d83fc

Browse files
metascroymalfet
authored andcommitted
Use Xcode_15.3 on arm64 CI jobs and switch ExecuTorch back to "viable/strict" (#619)
* clean up et install * switch to 15.3 * changes * fixes * set version in with clause * setup xcode block * remove ubunut runner-et temporarily * conditionally enable xcode setup on macOS
1 parent df3274a commit a5d83fc

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

.github/workflows/pull.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,6 +435,11 @@ jobs:
435435
uses: actions/setup-python@v2
436436
with:
437437
python-version: 3.10.11
438+
- name: Setup Xcode
439+
if: runner.os == 'macOS'
440+
uses: maxim-lobanov/setup-xcode@v1
441+
with:
442+
xcode-version: '15.3'
438443
- name: Print machine info
439444
run: |
440445
uname -a
@@ -864,7 +869,7 @@ jobs:
864869
runner-et:
865870
strategy:
866871
matrix:
867-
runner: [macos-14-xlarge, 8-core-ubuntu]
872+
runner: [16-core-ubuntu, macos-14-xlarge]
868873
runs-on: ${{matrix.runner}}
869874
steps:
870875
- name: Checkout repo
@@ -875,6 +880,11 @@ jobs:
875880
uses: actions/setup-python@v2
876881
with:
877882
python-version: 3.10.11
883+
- name: Setup Xcode
884+
if: runner.os == 'macOS'
885+
uses: maxim-lobanov/setup-xcode@v1
886+
with:
887+
xcode-version: '15.3'
878888
- name: Print machine info
879889
run: |
880890
uname -a

requirements.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
# Requires python >=3.10
22

33
# PyTorch ecosystem
4-
#torch==2.4.0.dev20240422
54
torchao
6-
# executorch==0.1.2
75

86
# Hugging Face download
97
huggingface_hub

scripts/install_utils.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ install_pip_dependencies() {
1111
echo "Intalling common pip packages"
1212
pip3 install wheel "cmake>=3.19" ninja zstd
1313
pushd ${TORCHCHAT_ROOT}
14-
pip3 install -r ./requirements.txt --extra-index-url https://download.pytorch.org/whl/nightly/cu121
14+
pip3 install -r ./requirements.txt
1515
popd
1616
}
1717

@@ -27,7 +27,7 @@ clone_executorch() {
2727
pushd ${TORCHCHAT_ROOT}/${ET_BUILD_DIR}/src
2828
git clone https://github.com/pytorch/executorch.git
2929
cd executorch
30-
git checkout f0f4db877dd649c4e8ce951a4ccc3827841e9ad3
30+
git checkout "viable/strict"
3131
echo "Install executorch: submodule update"
3232
git submodule sync
3333
git submodule update --init

0 commit comments

Comments
 (0)