Make sure size_test CI uses -Wall -Werror

Author: mergennachin

runtime/kernel/operator_registry.cpp

@@ -135,7 +135,7 @@ void make_kernel_key_string(Span<const TensorMeta> key, char* buf) {
     // If no tensor is present in an op, kernel key does not apply
     return;
   }
-  strncpy(buf, "v1/", 3);
+  strcpy(buf, "v1/");
   buf += 3;
   for (size_t i = 0; i < key.size(); i++) {
     auto& meta = key[i];

test/build_size_test.sh

@@ -14,8 +14,9 @@ source "$(dirname "${BASH_SOURCE[0]}")/../.ci/scripts/utils.sh"
 cmake_install_executorch_lib() {
   echo "Installing libexecutorch.a"
   clean_executorch_install_folders
-
-  CXXFLAGS="-fno-exceptions -fno-rtti" retry cmake -DBUCK2="$BUCK2" \
+  
+  # Remove -Wno-sign-compare (https://github.com/pytorch/executorch/issues/8149)
+  CXXFLAGS="-fno-exceptions -fno-rtti -Wall -Werror -Wno-sign-compare" retry cmake -DBUCK2="$BUCK2" \
           -DCMAKE_CXX_STANDARD_REQUIRED=ON \
           -DCMAKE_INSTALL_PREFIX=cmake-out \
           -DCMAKE_BUILD_TYPE=Release \
@@ -27,7 +28,8 @@ cmake_install_executorch_lib() {
 }
 
 test_cmake_size_test() {
-    CXXFLAGS="-fno-exceptions -fno-rtti" retry cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=cmake-out -Bcmake-out/test test
+    # Remove -Wno-sign-compare (https://github.com/pytorch/executorch/issues/8149)
+    CXXFLAGS="-fno-exceptions -fno-rtti -Wall -Werror -Wno-sign-compare" retry cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=cmake-out -Bcmake-out/test test
 
     echo "Build size test"
     cmake --build cmake-out/test -j9 --config Release