Skip to content

Commit ae9b018

Browse files
committed
Update on "Use std::variant to implement pytree Key"
Key was a struct that should've been a union; std::variant makes using a union much easier. Differential Revision: [D65575184](https://our.internmc.facebook.com/intern/diff/D65575184/) [ghstack-poisoned]
1 parent c5f21bc commit ae9b018

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

extension/pytree/pytree.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ using KeyInt = int32_t;
5555

5656
struct Key {
5757
enum class Kind : uint8_t { None, Int, Str } kind_;
58+
5859
private:
5960
std::variant<std::monostate, KeyInt, KeyStr> repr_;
6061

0 commit comments

Comments
 (0)