Remove RemoveRedundantViewCopyPass (#2464)

Summary:

The RemoveRedundantViewCopyPass is unnecessary and can be replaced by NormalizeViewCopyBasePass + dead code elimintation.

Reviewed By: larryliu0820

Differential Revision: D54866523

Author: metascroy

exir/passes/normalize_view_copy_base_pass.py

@@ -14,26 +14,24 @@
 from torch.fx.passes.infra.pass_base import PassBase, PassResult
 
 
-def _is_view_copy(node: torch.fx.Node) -> bool:
+def _is_view_copy(node: torch.fx.Node) -> bool:  # pyre-ignore[11]
     return node.op == "call_function" and node.target in (
         torch.ops.aten.view_copy.default,
         ops.edge.aten.view_copy.default,
     )
 
 
-class NormalizeViewCopyBasePass(PassBase):
+class NormalizeViewCopyBasePass(PassBase):  # pyre-ignore[11]
     """
     Point each view_copy to the first upstream non-view.
 
     After this pass, the base of each view_copy is not a view_copy.
 
     When combined with dead-code elimination, this pass removes redundant
     view_copy nodes.
-
-    TODO: replace RemoveRedundantViewCopyPass with NormalizeViewCopyBasePass + dead code elimination.
     """
 
-    def call(self, graph_module: torch.fx.GraphModule) -> PassResult:
+    def call(self, graph_module: torch.fx.GraphModule) -> PassResult:  # pyre-ignore[11]
         n_updated = 0
         for module in graph_module.modules():
             if not isinstance(module, torch.fx.GraphModule):

exir/program/_program.py

@@ -24,6 +24,7 @@
 from executorch.exir.passes import (
     base_post_op_replace_passes,
     base_pre_op_replace_passes,
+    dead_code_elimination_pass,
     EdgeToBackendOpsPass,
     MemoryFormatOpsPass,
     OpReplacePass,
@@ -626,6 +627,7 @@ def pre_memory_planning_passes(config: ExecutorchBackendConfig) -> List[PassType
         # pyre-ignore
         return [
             NormalizeViewCopyBasePass(),
+            dead_code_elimination_pass,
             ReplaceViewCopyWithViewPass(),
             config.sym_shape_eval_pass,
             config.to_out_var_pass,