Apply suggestions from code review

malfet · web-flow · commit bd8de1b2e4d5 · 2024-04-23T17:45:50.000-07:00
diff --git a/kernels/portable/cpu/op_isinf.cpp b/kernels/portable/cpu/op_isinf.cpp
@@ -15,7 +15,7 @@ namespace executor {
 namespace native {
 
 Tensor& isinf_out(RuntimeContext& ctx, const Tensor& in, Tensor& out) {
-  return internal::unary_ufunc_realhb_to_bool([](double x) {return std::isinf(x); }, ctx, in, out);
+  return internal::unary_ufunc_realhb_to_bool(static_cast<bool(*)(double)>(std::isinf), ctx, in, out);
 }
 
 } // namespace native
diff --git a/kernels/portable/cpu/op_isnan.cpp b/kernels/portable/cpu/op_isnan.cpp
@@ -15,7 +15,7 @@ namespace executor {
 namespace native {
 
 Tensor& isnan_out(RuntimeContext& ctx, const Tensor& in, Tensor& out) {
-  return internal::unary_ufunc_realhb_to_bool([](double x) { return ::std::isnan(x); }, ctx, in, out);
+  return internal::unary_ufunc_realhb_to_bool(static_cast<bool(*)(double)>(std::isnan), ctx, in, out);
 }
 
 } // namespace native

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ namespace executor {`
`15`	`15`	`namespace native {`
`16`	`16`
`17`	`17`	`Tensor& isinf_out(RuntimeContext& ctx, const Tensor& in, Tensor& out) {`
`18`		`- return internal::unary_ufunc_realhb_to_bool([](double x) {return std::isinf(x); }, ctx, in, out);`
	`18`	`+ return internal::unary_ufunc_realhb_to_bool(static_cast<bool(*)(double)>(std::isinf), ctx, in, out);`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`} // namespace native`