Skip to content

Commit be77c5f

Browse files
Gasoonjiafacebook-github-bot
authored andcommitted
remove unused aten_compatible argument
Summary: aten_compatible argument is no longer used in the op_test function. Remove that for mis-leading. Differential Revision: D54778606
1 parent 8487a23 commit be77c5f

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

kernels/portable/test/targets.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ def define_common_targets():
88
"""
99
define_supported_features_lib()
1010

11-
op_test(name = "op_allclose_test", aten_compatible = False)
11+
op_test(name = "op_allclose_test")
1212
op_test(name = "op_div_test")
1313
op_test(name = "op_gelu_test")
1414
op_test(name = "op_mul_test")

kernels/test/targets.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
22
load("@fbsource//xplat/executorch/kernels/test:util.bzl", "codegen_function_header_wrapper", "generated_op_test", "op_test")
33

4-
def _common_op_test(name, kernels, aten_compatible = True):
4+
def _common_op_test(name, kernels):
55
"""
66
Defines test targets in format of <kernel>_op_<op-name>_test
77
For ATen kernel testing, let's use portable functions.yaml for tested ops.
88
"""
99
for kernel in kernels:
1010
deps = [":function_header_wrapper_{}".format(kernel)]
11-
op_test(name, aten_compatible = aten_compatible, kernel_name = kernel, use_kernel_prefix = True, deps = deps)
11+
op_test(name, kernel_name = kernel, use_kernel_prefix = True, deps = deps)
1212

1313
def make_example_generated_op_test_target():
1414
"""

kernels/test/util.bzl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_xplat")
22
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
33

4-
def op_test(name, deps = [], aten_compatible = True, kernel_name = "portable", use_kernel_prefix = False):
4+
def op_test(name, deps = [], kernel_name = "portable", use_kernel_prefix = False):
55
"""Defines a cxx_test() for an "op_*_test.cpp" file.
66
77
Args:
@@ -11,8 +11,6 @@ def op_test(name, deps = [], aten_compatible = True, kernel_name = "portable", u
1111
under //kernels/<kernel>/...; e.g., "op_add_test" will depend on
1212
"//kernels/portable/cpu:op_add".
1313
deps: Optional extra deps to add to the cxx_test().
14-
aten_compatible: If True, the operator under test is ATen-compatible
15-
(i.e., appears in `functions.yaml`).
1614
kernel_name: The name string as in //executorch/kernels/<kernel_name>.
1715
use_kernel_prefix: If True, the target name is
1816
<kernel>_op_<operator-group-name>_test. Used by common kernel testing.

0 commit comments

Comments
 (0)