Fix -Wglobal-constructors/-Wshadow for executor_runner targets (#9509)

Disable one, fix the other.

Testing: built internally

Author: swolchok

examples/portable/executor_runner/executor_runner.cpp

@@ -302,7 +302,7 @@ int main(int argc, char** argv) {
   if (tracer.get_event_tracer()) {
     // Dump ETDump data containing profiling/debugging data to file specified in
     // command line flag.
-    Error status = tracer.write_etdump_to_file();
+    status = tracer.write_etdump_to_file();
     ET_CHECK_MSG(status == Error::Ok, "Failed to save ETDump file.");
   }
 

examples/portable/executor_runner/targets.bzl

@@ -13,6 +13,7 @@ def define_common_targets():
     runtime.cxx_library(
         name = "executor_runner_lib",
         srcs = ["executor_runner.cpp"],
+        compiler_flags = ["-Wno-global-constructors"],
         deps = [
             "//executorch/runtime/executor:program",
             "//executorch/devtools/etdump:etdump_flatcc",
@@ -32,6 +33,7 @@ def define_common_targets():
     runtime.cxx_library(
         name = "executor_runner_lib_with_threadpool",
         srcs = ["executor_runner.cpp"],
+        compiler_flags = ["-Wno-global-constructors"],
         deps = [
             "//executorch/runtime/executor:program",
             "//executorch/extension/data_loader:file_data_loader",