Skip to content

Commit d4c9a30

Browse files
authored
[jit] Remove TorchScript from doc (#10825)
Summary: As titled. This removes TorchScript from a bunch of readmes, given that they are not needed. Test Plan: Reviewers: Subscribers: Tasks: Tags: ### Summary [PLEASE REMOVE] See [CONTRIBUTING.md's Pull Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests) for ExecuTorch PR guidelines. [PLEASE REMOVE] If this PR closes an issue, please add a `Fixes #<issue-id>` line. [PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: <area>" label. For a list of available release notes labels, check out [CONTRIBUTING.md's Pull Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests). ### Test plan [PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.
1 parent e3a6825 commit d4c9a30

File tree

3 files changed

+5
-12
lines changed

3 files changed

+5
-12
lines changed

examples/demo-apps/android/LlamaDemo/docs/delegates/xnnpack_README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ python -m pytorch_tokenizers.tools.llama2c.convert -t tokenizer.model -o tokeniz
113113
### For LLaVA model
114114
* For the Llava 1.5 model, you can get it from Huggingface [here](https://huggingface.co/llava-hf/llava-1.5-7b-hf).
115115
* Run `examples/models/llava/install_requirements.sh` to install dependencies.
116-
* Run the following command to generate llava.pte, tokenizer.bin and an image tensor (serialized in TorchScript) image.pt.
116+
* Run the following command to generate llava.pte, tokenizer.bin and download an image basketball.jpg.
117117

118118
```
119119
python -m executorch.examples.models.llava.export_llava --pte-name llava.pte --with-artifacts

examples/demo-apps/apple_ios/LLaMA/docs/delegates/xnnpack_README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ python -m examples.models.llama.export_llama --checkpoint <path-to-your-checkpoi
8585
### For LLaVA model
8686
* For the Llava 1.5 model, you can get it from Huggingface [here](https://huggingface.co/llava-hf/llava-1.5-7b-hf).
8787
* Run `examples/models/llava/install_requirements.sh` to install dependencies.
88-
* Run the following command to generate llava.pte, tokenizer.bin and an image tensor (serialized in TorchScript) image.pt.
88+
* Run the following command to generate llava.pte, tokenizer.bin and download an image basketball.jpg.
8989

9090
```
9191
python -m executorch.examples.models.llava.export_llava --pte-name llava.pte --with-artifacts

examples/models/llava/README.md

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,8 @@ The model weights is 15GiB, and the other memory usage at export stage (`export_
4141

4242
### Generate ExecuTorch .PTE and other artifacts
4343

44-
Run the following command to generate `llava.pte`, `tokenizer.bin` and an image
45-
tensor (serialized in TorchScript) `image.pt`.
44+
Run the following command to generate `llava.pte`, `tokenizer.bin` and an image `basketball.jpg`.
4645

47-
> **Warning**: The C++ runner `llava_main` binary cannot process raw image inputs such as JPEG, PNG, or BMP files directly. You must convert these images to a `.pt` file format using the `examples/models/llava/image_util.py` script before using them with `llava_main`.
4846

4947
Prerequisite: run `install_executorch.sh` to install ExecuTorch and run
5048
`examples/models/llava/install_requirements.sh` to install dependencies.
@@ -65,11 +63,6 @@ python -m executorch.examples.models.llava.test.test_pte llava.pte
6563
See or run `.ci/scripts/test_llava.sh` shell script to build a C++ runner. This
6664
script also has preliminary support to build the C++ runner for Android.
6765

68-
This also has an image utility Python script to generate image in PyTorch
69-
loadable format. Alternatively, we are working on generating image format which
70-
doesn't need PyTorch to load an image. Motivation for this is to build the C++
71-
runner on Android.
72-
7366
Then you should be able to find `llava_main` binary:
7467

7568
```bash
@@ -104,8 +97,8 @@ Run:
10497
cmake-out/examples/models/llava/llava_main \
10598
--model_path=llava.pte \
10699
--tokenizer_path=tokenizer.bin \
107-
--image_path=image.pt \
108-
--prompt="ASSISTANT:" \
100+
--image_path=basketball.jpg \
101+
--prompt="ASSISTANT:" \
109102
--seq_len=768 \
110103
--temperature=0
111104
```

0 commit comments

Comments
 (0)