Make compare_results() import path public (#5225)

Summary:
Pull Request resolved: #5225

`compare_results()` is a util function that is used outside of the inspector tool itself. We will also probably mention it in PTC as a public util function. This diff makes it "public" aka removes the underscore prefix in the import paths.

Reviewed By: dbort

Differential Revision: D62450959

fbshipit-source-id: 5688a79001b76c2e99ac76a9238828c6031f7291

Author: Olivia-liu

devtools/inspector/TARGETS

@@ -26,8 +26,8 @@ python_binary(
     main_function = ".inspector_cli.main",
     main_src = "inspector_cli.py",
     deps = [
-        ":inspector_utils",
         "//executorch/devtools:lib",
+        "//executorch/devtools/inspector:lib",
     ],
 )
 

devtools/inspector/__init__.py

@@ -4,12 +4,21 @@
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
+# pyre-unsafe
+
 from executorch.devtools.inspector._inspector import (
     Event,
     EventBlock,
     Inspector,
     PerfData,
 )
-from executorch.devtools.inspector._inspector_utils import TimeScale
+from executorch.devtools.inspector._inspector_utils import compare_results, TimeScale
 
-__all__ = ["Event", "EventBlock", "Inspector", "PerfData", "TimeScale"]
+__all__ = [
+    "Event",
+    "EventBlock",
+    "Inspector",
+    "PerfData",
+    "compare_results",
+    "TimeScale",
+]

devtools/inspector/inspector_cli.py

@@ -4,10 +4,12 @@
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
+# pyre-unsafe
+
 import argparse
 
 from executorch.devtools import Inspector
-from executorch.devtools.inspector._inspector_utils import compare_results, TimeScale
+from executorch.devtools.inspector import compare_results, TimeScale
 
 
 def main() -> None:

docs/source/sdk-debugging.md

@@ -67,7 +67,7 @@ We've also provided a simple set of utilities that let users perform quality ana
 
 
 ```python
-from executorch.devtools.inspector._inspector_utils import compare_results
+from executorch.devtools.inspector import compare_results
 
 # Run a simple quality analysis between the model outputs sourced from the
 # runtime and a set of reference outputs.

examples/apple/coreml/scripts/inspector_cli.py

@@ -9,7 +9,7 @@
 from pathlib import Path
 
 from executorch.devtools import Inspector
-from executorch.devtools.inspector._inspector_utils import compare_results
+from executorch.devtools.inspector import compare_results
 
 
 def get_root_dir_path() -> Path: