Skip to content

Commit d7626f2

Browse files
kirklandsignfacebook-github-bot
authored andcommitted
XNNPACK workflow don't stop on one run error (#1077)
Summary: Instead, need to wait for all options (quantization/delegation) and report error in the end. See https://github.com/pytorch/executorch/actions/runs/6631014744/job/18013650086?pr=1077, now we run all models, and see useful info like `Portable q8 ok, Delegation fp32 error, Delegation q8 error` Pull Request resolved: #1077 Reviewed By: huydhn Differential Revision: D50610446 Pulled By: kirklandsign fbshipit-source-id: 1985c519026b8a28ad5512f993e65b88254694fb
1 parent 427641c commit d7626f2

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

.ci/scripts/test.sh

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,21 +151,27 @@ if [[ "${BACKEND}" == "portable" ]]; then
151151
echo "Testing ${MODEL_NAME} with portable kernels..."
152152
test_model
153153
else
154+
set +e
154155
if [[ "${BACKEND}" == *"quantization"* ]]; then
155156
echo "::group::Testing ${MODEL_NAME} with XNNPACK quantization only..."
156-
test_model_with_xnnpack true false
157+
test_model_with_xnnpack true false || Q_ERROR="error"
157158
echo "::endgroup::"
158159
fi
159160
if [[ "${BACKEND}" == *"delegation"* ]]; then
160161
echo "::group::Testing ${MODEL_NAME} with XNNPACK delegation only..."
161-
test_model_with_xnnpack false true
162+
test_model_with_xnnpack false true || D_ERROR="error"
162163
echo "::endgroup::"
163164
fi
164165
if [[ "${BACKEND}" == *"quantization"* ]] && [[ "${BACKEND}" == *"delegation"* ]]; then
165166
echo "::group::Testing ${MODEL_NAME} with XNNPACK quantization and delegation..."
166-
test_model_with_xnnpack true true
167+
test_model_with_xnnpack true true || Q_D_ERROR="error"
167168
echo "::endgroup::"
168169
fi
170+
set -e
171+
if [[ -n "${Q_ERROR:-}" ]] || [[ -n "${D_ERROR:-}" ]] || [[ -n "${Q_D_ERROR:-}" ]]; then
172+
echo "Portable q8 ${Q_ERROR:-ok}," "Delegation fp32 ${D_ERROR:-ok}," "Delegation q8 ${Q_D_ERROR:-ok}"
173+
exit 1
174+
fi
169175
fi
170176

171177
# Test demo backend delegation

0 commit comments

Comments
 (0)