Skip to content

Commit e31cb6a

Browse files
authored
Correct the build for the ninja generator
The problem comes from the generated command that contains `rm -f` for the bid dir that in case of using ninja generator will contain several directories ``` FAILED: devtools/include/executorch/devtools/etdump/etdump_schema_flatcc_reader.h devtools/include/executorch/devtools/etdump/etdump_schema_flatcc_builder.h devtools/include/executorch/devtools/etdump/scalar_type_reader.h devtools/include/executorch/devtools/etdump/scalar_type_builder.h /Volumes/workplace/sample-project/build/default/devtools/include/executorch/devtools/etdump/etdump_schema_flatcc_reader.h /Volumes/workplace/sample-project/build/default/devtools/include/executorch/devtools/etdump/etdump_schema_flatcc_builder.h /Volumes/workplace/sample-project/build/default/devtools/include/executorch/devtools/etdump/scalar_type_reader.h /Volumes/workplace/sample-project/build/default/devtools/include/executorch/devtools/etdump/scalar_type_builder.h cd /Volumes/workplace/sample-project/build/default/vendor/executorch/devtools && /Volumes/workplace/sample-project/vendor/executorch/devtools/../third-party/flatcc/bin/flatcc -cwr -o /Volumes/workplace/sample-project/build/default/devtools/include/executorch/devtools/etdump /Volumes/workplace/sample-project/vendor/executorch/devtools/etdump/etdump_schema_flatcc.fbs /Volumes/workplace/sample-project/vendor/executorch/devtools/etdump/scalar_type.fbs && rm -f /Volumes/workplace/sample-project/vendor/executorch/devtools/../third-party/flatcc/bin/* /Volumes/workplace/sample-project/vendor/executorch/devtools/../third-party/flatcc/lib/* rm: /Volumes/workplace/sample-project/vendor/executorch/devtools/../third-party/flatcc/bin/Debug: is a directory rm: /Volumes/workplace/sample-project/vendor/executorch/devtools/../third-party/flatcc/bin/RelWithDebInfo: is a directory rm: /Volumes/workplace/sample-project/vendor/executorch/devtools/../third-party/flatcc/bin/Release: is a directory rm: /Volumes/workplace/sample-project/vendor/executorch/devtools/../third-party/flatcc/lib/Debug: is a directory rm: /Volumes/workplace/sample-project/vendor/executorch/devtools/../third-party/flatcc/lib/RelWithDebInfo: is a directory rm: /Volumes/workplace/sample-project/vendor/executorch/devtools/../third-party/flatcc/lib/Release: is a directory ``` Note the lines ``` rm: /Volumes/workplace/sample-project/vendor/executorch/devtools/../third-party/flatcc/bin/Debug: is a directory ```
1 parent cf16b85 commit e31cb6a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

devtools/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ add_custom_command(
166166
${_flatcc_source_dir}/bin/flatcc -cwr -o
167167
${_program_schema__include_dir}/executorch/devtools/etdump
168168
${_etdump_schema__srcs}
169-
COMMAND rm -f ${_etdump_schema_cleanup_paths}
169+
COMMAND rm -rf ${_etdump_schema_cleanup_paths}
170170
DEPENDS ${_etdump_schema_gen_dep}
171171
COMMENT "Generating etdump headers"
172172
)

0 commit comments

Comments
 (0)