You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[pybind] Add back extension suffix for portable lib shared object in wheel
Summary: Initially our portable lib prebuilt library is named as:
```
_portable_lib.cpython-310-x86_64-linux-gnu.so
```
Where it includes an `EXT_SUFFIX` `cpython-310-x86_64-linux-gnu` consists of architecture and build OS
information.
This is enforced by `setuptools` following PEP 3149 and there's no good
way to change this behavior.
which is easier to be found by `find_package()` macro in CMake.
However #5961 is breaking the other prebuilt libraries such as
`libcustom_ops_aot_lib.so` which depends on the original
`_portable_lib.cpython-310-x86_64-linux-gnu.so` name in its RPATH.
This PR is a fix that reverts #5961 and restore the full name during
packaging, but try to match the `EXT_SUFFIX` in CMake to be able to find
the .so file.
Test Plan:
```bash
python -c "from executorch.extension.llm.custom_ops import
sdpa_with_kv_cache"
```
Does not throw `_portable_lib.cpython-310-x86_64-linux-gnu.so` not found
error.
Reviewers:
Subscribers:
Tasks:
Tags:
0 commit comments