pybind env var (#2447)

lucylq · facebook-github-bot · commit e4ea524f77ab · 2024-03-14T19:15:59.000-07:00
Summary: Pull Request resolved: #2447 Check the value of `EXECUTORCH_BUILD_PYBIND`, by default set to false, and build pybind if on. Previously, seeing error P1196368933 when running ./install_requirements.sh , without `--pybind` flag. Reviewed By: shoumikhin Differential Revision: D54928464 fbshipit-source-id: 2513eff44399cb2396fdee150aefc933af82dc73
diff --git a/setup.py b/setup.py
@@ -229,7 +229,7 @@ def run(self):
     "egg_info": CustomEggInfoCommand,
 }
 ext_modules = None
-if os.environ.get("EXECUTORCH_BUILD_PYBIND", None):
+if os.environ.get("EXECUTORCH_BUILD_PYBIND", "OFF") == "ON":
     cmdclass["build_ext"] = CMakeBuild
     ext_modules = [CMakeExtension("executorch.extension.pybindings.portable_lib")]
 

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ def run(self):`
`229`	`229`	`"egg_info": CustomEggInfoCommand,`
`230`	`230`	`}`
`231`	`231`	`ext_modules = None`
`232`		`-if os.environ.get("EXECUTORCH_BUILD_PYBIND", None):`
	`232`	`+if os.environ.get("EXECUTORCH_BUILD_PYBIND", "OFF") == "ON":`
`233`	`233`	`cmdclass["build_ext"] = CMakeBuild`
`234`	`234`	`ext_modules = [CMakeExtension("executorch.extension.pybindings.portable_lib")]`
`235`	`235`