Fix Android test linkage (#2319)

jorgep31415 · facebook-github-bot · commit e5c285386be3 · 2024-03-08T12:45:40.000-08:00
Summary: bypass-github-export-checks Pull Request resolved: #2319 In #2305, I added the `soname = "libvulkan_graph_runtime.$(ext)"` to the wrong library. Noob mistake. Also, I'd forgotten to remove an unneeded dependency. Reviewed By: SS-JIA Differential Revision: D54688153 fbshipit-source-id: 67a1316c76180030d4ae5225f16f01dcc750220a
diff --git a/backends/vulkan/targets.bzl b/backends/vulkan/targets.bzl
@@ -60,6 +60,8 @@ def define_common_targets():
         # therefore link_whole must be True to make sure unused symbols are not discarded.
         # @lint-ignore BUCKLINT: Avoid `link_whole=True`
         link_whole = True,
+        # Define an soname that can be used for dynamic loading in Java, Python, etc.
+        soname = "libvulkan_graph_runtime.$(ext)",
     )
 
     runtime.cxx_library(
@@ -85,6 +87,4 @@ def define_common_targets():
         # VulkanBackend.cpp needs to compile with executor as whole
         # @lint-ignore BUCKLINT: Avoid `link_whole=True` (https://fburl.com/avoid-link-whole)
         link_whole = True,
-        # Define an soname that can be used for dynamic loading in Java, Python, etc.
-        soname = "libvulkan_graph_runtime.$(ext)",
     )

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,8 @@ def define_common_targets():`
`60`	`60`	`# therefore link_whole must be True to make sure unused symbols are not discarded.`
`61`	`61`	# @lint-ignore BUCKLINT: Avoid `link_whole=True`
`62`	`62`	`link_whole = True,`
	`63`	`+ # Define an soname that can be used for dynamic loading in Java, Python, etc.`
	`64`	`+ soname = "libvulkan_graph_runtime.$(ext)",`
`63`	`65`	`)`
`64`	`66`
`65`	`67`	`runtime.cxx_library(`
`@@ -85,6 +87,4 @@ def define_common_targets():`
`85`	`87`	`# VulkanBackend.cpp needs to compile with executor as whole`
`86`	`88`	# @lint-ignore BUCKLINT: Avoid `link_whole=True` (https://fburl.com/avoid-link-whole)
`87`	`89`	`link_whole = True,`
`88`		`- # Define an soname that can be used for dynamic loading in Java, Python, etc.`
`89`		`- soname = "libvulkan_graph_runtime.$(ext)",`
`90`	`90`	`)`