Skip to content

Commit e9aa542

Browse files
kirklandsignfacebook-github-bot
authored andcommitted
Add tiktoken OFF/ON options for android prebuilt aar (#4203)
Summary: BPE (tiktoken OFF) is for llama2, and tiktoken ON is for llama3. Pull Request resolved: #4203 Reviewed By: cccclai Differential Revision: D59608775 Pulled By: kirklandsign fbshipit-source-id: b1bb9411982b078b752eb67a48e84d308db5ac07
1 parent d8c4afa commit e9aa542

File tree

1 file changed

+15
-16
lines changed

1 file changed

+15
-16
lines changed

.github/workflows/android.yml

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ jobs:
2727
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
2828
strategy:
2929
matrix:
30-
include:
31-
- build-tool: buck2
30+
tiktoken: [OFF, ON]
3231
with:
3332
# NB: The example model dl3 requires lots of memory (T161064121)
3433
runner: linux.12xlarge
@@ -44,30 +43,30 @@ jobs:
4443
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
4544
conda activate "${CONDA_ENV}"
4645
47-
BUILD_TOOL=${{ matrix.build-tool }}
4846
# Setup MacOS dependencies as there is no Docker support on MacOS atm
49-
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh "${BUILD_TOOL}"
47+
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh buck2
5048
# Build Android library
49+
export EXECUTORCH_USE_TIKTOKEN=${{ matrix.tiktoken }}
5150
bash build/build_android_library.sh
5251
# Build Android demo app
5352
bash build/test_android_ci.sh
5453
55-
mkdir -p artifacts-to-be-uploaded
56-
mkdir -p artifacts-to-be-uploaded/arm64-v8a/
57-
mkdir -p artifacts-to-be-uploaded/x86_64/
54+
mkdir -p artifacts-to-be-uploaded/tiktoken_$EXECUTORCH_USE_TIKTOKEN
55+
mkdir -p artifacts-to-be-uploaded/tiktoken_$EXECUTORCH_USE_TIKTOKEN/arm64-v8a/
56+
mkdir -p artifacts-to-be-uploaded/tiktoken_$EXECUTORCH_USE_TIKTOKEN/x86_64/
5857
# Copy the jar to S3
59-
cp extension/android/build/libs/executorch.jar artifacts-to-be-uploaded/
58+
cp extension/android/build/libs/executorch.jar artifacts-to-be-uploaded/tiktoken_$EXECUTORCH_USE_TIKTOKEN/
6059
# Copy the app and its test suite to S3
61-
cp examples/demo-apps/android/LlamaDemo/app/build/outputs/apk/debug/*.apk artifacts-to-be-uploaded/
62-
cp examples/demo-apps/android/LlamaDemo/app/build/outputs/apk/androidTest/debug/*.apk artifacts-to-be-uploaded/
60+
cp examples/demo-apps/android/LlamaDemo/app/build/outputs/apk/debug/*.apk artifacts-to-be-uploaded/tiktoken_$EXECUTORCH_USE_TIKTOKEN/
61+
cp examples/demo-apps/android/LlamaDemo/app/build/outputs/apk/androidTest/debug/*.apk artifacts-to-be-uploaded/tiktoken_$EXECUTORCH_USE_TIKTOKEN/
6362
# Also copy the libraries
64-
cp cmake-out-android-arm64-v8a/lib/*.a artifacts-to-be-uploaded/arm64-v8a/
65-
cp cmake-out-android-arm64-v8a/extension/android/*.so artifacts-to-be-uploaded/arm64-v8a/
66-
cp cmake-out-android-x86_64/lib/*.a artifacts-to-be-uploaded/x86_64/
67-
cp cmake-out-android-x86_64/extension/android/*.so artifacts-to-be-uploaded/x86_64/
63+
cp cmake-out-android-arm64-v8a/lib/*.a artifacts-to-be-uploaded/tiktoken_$EXECUTORCH_USE_TIKTOKEN/arm64-v8a/
64+
cp cmake-out-android-arm64-v8a/extension/android/*.so artifacts-to-be-uploaded/tiktoken_$EXECUTORCH_USE_TIKTOKEN/arm64-v8a/
65+
cp cmake-out-android-x86_64/lib/*.a artifacts-to-be-uploaded/tiktoken_$EXECUTORCH_USE_TIKTOKEN/x86_64/
66+
cp cmake-out-android-x86_64/extension/android/*.so artifacts-to-be-uploaded/tiktoken_$EXECUTORCH_USE_TIKTOKEN/x86_64/
6867
# Copyp AAR to S3
69-
cp executorch.aar artifacts-to-be-uploaded/
70-
cp executorch-llama.aar artifacts-to-be-uploaded/
68+
cp executorch.aar artifacts-to-be-uploaded/tiktoken_$EXECUTORCH_USE_TIKTOKEN/
69+
cp executorch-llama.aar artifacts-to-be-uploaded/tiktoken_$EXECUTORCH_USE_TIKTOKEN/
7170
7271
# Upload the app and its test suite to S3 so that they can be downloaded by the test job
7372
upload-artifacts:

0 commit comments

Comments
 (0)