Skip to content

Commit eae3004

Browse files
committed
Handle illegal character in benchmark configs filename
1 parent fc04436 commit eae3004

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/android-perf.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ jobs:
111111
# so let's just sed it
112112
sed -i -e 's,{{ model_path }},'"${MODEL_PATH}"',g' android-llm-device-farm-test-spec.yml.j2
113113
114-
BENCHMARK_CONFIG_ID="${{ matrix.model }}_${{ matrix.config }}"
114+
BENCHMARK_CONFIG_ID=$(echo "${{ matrix.model }}_${{ matrix.config }}" | sed -e 's/[^A-Za-z0-9._-]/_/g')
115115
# The config for this benchmark runs, we save it in the test spec so that it can be fetched
116116
# later by the upload script
117117
sed -i -e 's,{{ benchmark_config_id }},'"${BENCHMARK_CONFIG_ID}"',g' android-llm-device-farm-test-spec.yml.j2

.github/workflows/apple-perf.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ jobs:
113113
# so let's just sed it
114114
sed -i -e 's,{{ model_path }},'"${MODEL_PATH}"',g' default-ios-device-farm-appium-test-spec.yml.j2
115115
116-
BENCHMARK_CONFIG_ID="${{ matrix.model }}_${{ matrix.config }}"
116+
BENCHMARK_CONFIG_ID=$(echo "${{ matrix.model }}_${{ matrix.config }}" | sed -e 's/[^A-Za-z0-9._-]/_/g')
117117
# The config for this benchmark runs, we save it in the test spec so that it can be fetched
118118
# later by the upload script
119119
sed -i -e 's,{{ benchmark_config_id }},'"${BENCHMARK_CONFIG_ID}"',g' default-ios-device-farm-appium-test-spec.yml.j2

0 commit comments

Comments
 (0)