Delete loop unroll in SDPA op (#2438)

Shrey Desai · facebook-github-bot · commit eb976d2b6cd0 · 2024-03-15T08:58:49.000-07:00
Summary: Pull Request resolved: #2438 Delete #pragma unroll as it's causing compiler errors when building llama/runner.cpp for AOSP targets bypass-github-export-checks bypass-github-pytorch-ci-checks Reviewed By: kimishpatel Differential Revision: D54916248 fbshipit-source-id: 40b24e9d5f4af98bb961bacbeca94df8be71f989
diff --git a/examples/models/llama2/custom_ops/op_sdpa.cpp b/examples/models/llama2/custom_ops/op_sdpa.cpp
@@ -177,10 +177,6 @@ inline void fill_stub(scalar_t* data, scalar_t val, int64_t size) {
   for (; d < size - (size % Vec::size()); d += Vec::size()) {
     data_vec.store(data + d);
   }
-#if !defined(_MSC_VER) && !defined(COMPILING_FOR_MIN_SIZE) && \
-    !defined(__ANDROID__)
-#pragma unroll
-#endif
   for (; d < size; d++) {
     data[d] = val;
   }

Original file line number	Diff line number	Diff line change
`@@ -177,10 +177,6 @@ inline void fill_stub(scalar_t* data, scalar_t val, int64_t size) {`
`177`	`177`	`for (; d < size - (size % Vec::size()); d += Vec::size()) {`
`178`	`178`	`data_vec.store(data + d);`
`179`	`179`	`}`
`180`		`-#if !defined(_MSC_VER) && !defined(COMPILING_FOR_MIN_SIZE) && \`
`181`		`- !defined(__ANDROID__)`
`182`		`-#pragma unroll`
`183`		`-#endif`
`184`	`180`	`for (; d < size; d++) {`
`185`	`181`	`data[d] = val;`
`186`	`182`	`}`