Skip to content

Commit eca7a38

Browse files
committed
Address comments
1 parent 2996cb8 commit eca7a38

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

examples/apple/coreml/scripts/inspector_utils.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ def build_sdk_runner_including_coreml(
6767
"./examples/sdk/build_sdk_example_runner.sh --coreml"
6868
)
6969
build_command: str = (
70-
f"{cd_root_command}; {conda_activate_env_command}; {build_sdk_runner_command}"
70+
f"{cd_root_command} && {conda_activate_env_command} && {build_sdk_runner_command}"
7171
)
7272
subprocess.run(
7373
f'bash -c "{build_command}"', shell=True, check=True
@@ -189,9 +189,8 @@ def generate_etdump_with_intermediate_values(
189189
-etdump_path {et_dump_path.resolve()}\
190190
-debug_output_path {debug_buffer_path.resolve()}\
191191
-debug_buffer_size {debug_buffer_size}"""
192-
run_command: str = f"{sdk_runner_command}"
193192
subprocess.run(
194-
f'bash -c "{run_command}"', shell=True, check=True
193+
f'bash -c "{sdk_runner_command}"', shell=True, check=True
195194
).check_returncode()
196195

197196

examples/sdk/build_sdk_example_runner.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ done
3737
main() {
3838
cd "${EXECUTORCH_ROOT}"
3939

40-
# rm -rf cmake-out
40+
rm -rf cmake-out
4141

4242
if [[ "${BUILD_COREML}" == "ON" ]]; then
4343
cmake -DCMAKE_INSTALL_PREFIX=cmake-out \

0 commit comments

Comments
 (0)