You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* [ET-VK] Parse required extensions of shaders and check capabilities during dispatch
## Context
Now that we are using GLSL/SPIR-V extensions more heavily in our shaders, there is a risk that a particular shader uses an extension that is not supported by the physical device.
It is tedious to manually check that all the extensions required by a shader is supported by the device; it would be much more convenient for developers if there was an automated way to perform this check. This diff provides a solution for this.
Materially, this has manifested into an issue with our internal CI tests that run on Android emulator (which uses swiftshader under the hood). If the emulator tries to compile a shader that requires the `shaderInt16` feature, then the emulator will crash.
## Solution
1. Update `ShaderInfo` to have fields indicating whether certain extensions that require device support is required.
2. Update the `gen_vulkan_spv.py` shader compilation script to parse the GLSL code and log whether aforemention extensions are needed in the generated `ShaderInfo`.
3. Introduce a new exception class, `ShaderNotSupportedError`.
4. Before dispatching, check that all extensions required by the shader is supported by the device. If not, throw the new exception class.
4. In the generated operator correctness tests, skip the test if `ShaderNotSupportedError` is thrown.
Differential Revision: [D67992067](https://our.internmc.facebook.com/intern/diff/D67992067/)
ghstack-source-id: 260809479
Pull Request resolved: #7576
* [ET-VK][ez][buck] Simplify test buck file
## Context
The targets file for the op tests define a binary and test rule for each c++ file; instead of manually defining these rules each time, create a helper function to condense the code.
Differential Revision: [D67992066](https://our.internmc.facebook.com/intern/diff/D67992066/)
ghstack-source-id: 260809480
Pull Request resolved: #7577
---------
Co-authored-by: Stephen Jia <[email protected]>
0 commit comments