Skip to content

Commit ef94eed

Browse files
JacobSzwejbkafacebook-github-bot
authored andcommitted
delete load_from_buffer shared ptr api from pybindings module (#97)
Summary: Pull Request resolved: #97 unused so deleting Reviewed By: larryliu0820 Differential Revision: D48576223 fbshipit-source-id: 0c9266912b0dcf179a8ac79cf51678c2dff85058
1 parent eaf006e commit ef94eed

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

extension/pybindings/module.cpp

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,6 @@ class Module final {
114114
return run_method("forward", std::forward<Types>(args)...);
115115
}
116116

117-
void set_delete_memory(std::shared_ptr<char> mem_to_delete) {
118-
mem_to_delete_ = mem_to_delete;
119-
}
120-
121117
private:
122118
run_method_return_type run_method_internal(
123119
const std::string& method_name,
@@ -164,23 +160,11 @@ class Module final {
164160
return result;
165161
}
166162

167-
std::shared_ptr<char> mem_to_delete_; // loader_ may point to this.
168163
std::unique_ptr<DataLoader> loader_; // program_ points to this.
169164
std::unique_ptr<const Program> program_; // methods_ entries points to this.
170165
std::unordered_map<std::string, std::unique_ptr<Method>> methods_;
171166
};
172167

173-
inline std::unique_ptr<Module> load_from_buffer(
174-
std::shared_ptr<char> ptr,
175-
size_t ptr_len,
176-
MemoryManager* memory_manager) {
177-
EXECUTORCH_SCOPE_PROF("load_from_buffer");
178-
auto loader = std::make_unique<BufferDataLoader>(ptr.get(), ptr_len);
179-
auto m = std::make_unique<Module>(std::move(loader), memory_manager);
180-
m->set_delete_memory(std::move(ptr));
181-
return m;
182-
}
183-
184168
inline std::unique_ptr<Module> load_from_buffer(
185169
const void* ptr,
186170
size_t ptr_len,

0 commit comments

Comments
 (0)