Skip to content

Commit f25f135

Browse files
authored
[executorch] Migrate runtime/core tests to new namespace
Differential Revision: D60428952 Pull Request resolved: #4608
1 parent 3e4508a commit f25f135

9 files changed

+47
-39
lines changed

runtime/core/test/array_ref_test.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111
#include <gtest/gtest.h>
1212

1313
using namespace ::testing;
14-
15-
namespace torch {
16-
namespace executor {
14+
using executorch::runtime::ArrayRef;
1715

1816
TEST(TestArrayRef, ImplicitTypeConversion) {
1917
ArrayRef<int64_t> oneElement_1 = {1};
@@ -22,6 +20,3 @@ TEST(TestArrayRef, ImplicitTypeConversion) {
2220
ArrayRef<int64_t> oneElement_2 = 1;
2321
EXPECT_EQ(oneElement_2.size(), 1);
2422
}
25-
26-
} // namespace executor
27-
} // namespace torch

runtime/core/test/error_handling_test.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
#include <executorch/runtime/core/result.h>
1616
#include <executorch/runtime/platform/runtime.h>
1717

18-
using namespace torch::executor;
18+
using executorch::runtime::Error;
19+
using executorch::runtime::Result;
1920

2021
static void* test_ptr = static_cast<void*>((uintptr_t*)0xDEADBEEF);
2122

@@ -189,7 +190,7 @@ TEST(ErrorHandlingTest, ResultNoCopy) {
189190
}
190191

191192
TEST(ErrorHandlingTest, ResultMove) {
192-
torch::executor::runtime_init();
193+
executorch::runtime::runtime_init();
193194

194195
Result<Movable> res = Movable(2);
195196
ASSERT_TRUE(res.ok());

runtime/core/test/evalue_test.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515

1616
using namespace ::testing;
1717
using exec_aten::ScalarType;
18-
using torch::executor::BoxedEvalueList;
19-
using torch::executor::EValue;
20-
using torch::executor::Tag;
18+
using executorch::runtime::BoxedEvalueList;
19+
using executorch::runtime::EValue;
20+
using executorch::runtime::Tag;
2121
using torch::executor::testing::TensorFactory;
2222

2323
TEST(TestEValue, CopyTrivialType) {

runtime/core/test/event_tracer_test.cpp

Lines changed: 27 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,26 @@
88

99
#include <gtest/gtest.h>
1010

11+
#include <executorch/runtime/core/array_ref.h>
12+
#include <executorch/runtime/core/evalue.h>
1113
#include <executorch/runtime/core/event_tracer.h>
1214
// Enable flag for test
1315
#define ET_EVENT_TRACER_ENABLED
1416
#include <executorch/runtime/core/event_tracer_hooks.h>
1517
#include <executorch/runtime/core/event_tracer_hooks_delegate.h>
1618

17-
namespace torch {
18-
namespace executor {
19-
20-
using namespace internal;
19+
using exec_aten::Tensor;
20+
using executorch::runtime::AllocatorID;
21+
using executorch::runtime::ArrayRef;
22+
using executorch::runtime::ChainID;
23+
using executorch::runtime::DebugHandle;
24+
using executorch::runtime::EValue;
25+
using executorch::runtime::EventTracer;
26+
using executorch::runtime::EventTracerDebugLogLevel;
27+
using executorch::runtime::EventTracerEntry;
28+
using executorch::runtime::kUnsetChainId;
29+
using executorch::runtime::kUnsetDebugHandle;
30+
using executorch::runtime::LoggedEValueType;
2131

2232
class DummyEventTracer : public EventTracer {
2333
public:
@@ -159,6 +169,14 @@ class DummyEventTracer : public EventTracer {
159169
* Exercise all the event_tracer API's for a basic sanity check.
160170
*/
161171
void RunSimpleTracerTest(EventTracer* event_tracer) {
172+
using executorch::runtime::internal::event_tracer_begin_profiling_event;
173+
using executorch::runtime::internal::event_tracer_create_event_block;
174+
using executorch::runtime::internal::event_tracer_end_profiling_event;
175+
using executorch::runtime::internal::event_tracer_track_allocation;
176+
using executorch::runtime::internal::event_tracer_track_allocator;
177+
using executorch::runtime::internal::EventTracerProfileInstructionScope;
178+
using executorch::runtime::internal::EventTracerProfileScope;
179+
162180
event_tracer_create_event_block(event_tracer, "ExampleEvent");
163181
event_tracer_create_event_block(event_tracer, "ExampleEvent");
164182
EventTracerEntry event_entry =
@@ -216,6 +234,9 @@ TEST(TestEventTracer, SimpleEventTracerTestDelegate) {
216234
}
217235

218236
TEST(TestEventTracer, SimpleEventTracerTestLogging) {
237+
using executorch::runtime::internal::event_tracer_log_evalue;
238+
using executorch::runtime::internal::event_tracer_log_evalue_output;
239+
219240
EValue test_eval(true);
220241

221242
{
@@ -259,8 +280,5 @@ TEST(TestEventTracer, SimpleEventTracerTestLogging) {
259280
event_tracer_log_evalue_output(nullptr, test_eval);
260281
}
261282

262-
} // namespace executor
263-
} // namespace torch
264-
265-
// TODO : (T163645377) Add more test coverage to log and verify events passed
266-
// into DummyTracer.
283+
// TODO(T163645377): Add more test coverage to log and verify events passed into
284+
// DummyTracer.

runtime/core/test/freeable_buffer_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#include <gtest/gtest.h>
1212

1313
using namespace ::testing;
14-
using torch::executor::FreeableBuffer;
14+
using executorch::runtime::FreeableBuffer;
1515

1616
struct FreeCallArgs {
1717
size_t calls;

runtime/core/test/hierarchical_allocator_test.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,18 @@
1717
#include <gtest/gtest.h>
1818

1919
using namespace ::testing;
20-
using torch::executor::Error;
21-
using torch::executor::HierarchicalAllocator;
22-
using torch::executor::MemoryAllocator;
23-
using torch::executor::Result;
24-
using torch::executor::Span;
20+
using executorch::runtime::Error;
21+
using executorch::runtime::HierarchicalAllocator;
22+
using executorch::runtime::MemoryAllocator;
23+
using executorch::runtime::Result;
24+
using executorch::runtime::Span;
2525

2626
class HierarchicalAllocatorTest : public ::testing::Test {
2727
protected:
2828
void SetUp() override {
2929
// Since these tests cause ET_LOG to be called, the PAL must be initialized
3030
// first.
31-
torch::executor::runtime_init();
31+
executorch::runtime::runtime_init();
3232
}
3333
};
3434

runtime/core/test/memory_allocator_test.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
#include <gtest/gtest.h>
1717

1818
using namespace ::testing;
19-
using torch::executor::Error;
20-
using torch::executor::MemoryAllocator;
19+
using executorch::runtime::Error;
20+
using executorch::runtime::MemoryAllocator;
2121

2222
struct TestType8 {
2323
char data[8];
@@ -34,7 +34,7 @@ class MemoryAllocatorTest : public ::testing::Test {
3434
void SetUp() override {
3535
// Since these tests cause ET_LOG to be called, the PAL must be initialized
3636
// first.
37-
torch::executor::runtime_init();
37+
executorch::runtime::runtime_init();
3838
}
3939
};
4040

@@ -201,7 +201,7 @@ class HelperMacrosTest : public ::testing::Test {
201201
void SetUp() override {
202202
// Since these tests cause ET_LOG to be called, the PAL must be initialized
203203
// first.
204-
torch::executor::runtime_init();
204+
executorch::runtime::runtime_init();
205205
}
206206
};
207207

runtime/core/test/span_test.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@
1212
#include <gtest/gtest.h>
1313

1414
using namespace ::testing;
15-
16-
namespace torch {
17-
namespace executor {
15+
using executorch::runtime::Span;
1816

1917
TEST(SpanTest, Ctors) {
2018
int64_t x[2] = {1, 2};
@@ -64,6 +62,3 @@ TEST(SpanTest, TriviallyCopyable) {
6462
EXPECT_EQ(span.size(), span_copy.size());
6563
EXPECT_TRUE(std::is_trivially_copyable<Span<int64_t>>::value);
6664
}
67-
68-
} // namespace executor
69-
} // namespace torch

runtime/core/test/tensor_shape_dynamism_test_aten.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
#include <gtest/gtest.h>
1212

1313
using namespace ::testing;
14-
15-
using torch::executor::TensorShapeDynamism;
14+
using executorch::runtime::TensorShapeDynamism;
1615

1716
TEST(TensorShapeDynamismTest, CanBuildInATenMode) {
1817
// Demonstrate that aten mode can include the header and see the enum. If this

0 commit comments

Comments
 (0)