Skip to content

Commit f4b6645

Browse files
committed
Address review comments
1 parent badfe5e commit f4b6645

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

build/executorch-config.cmake

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,11 @@ foreach(lib ${lib_list})
5353
message("${lib} library is not found.
5454
If needed rebuild with the proper options in CMakeLists.txt")
5555
else()
56-
if("${lib}" STREQUAL "extension_module")
57-
if(CMAKE_TOOLCHAIN_IOS)
58-
# Building a share library on iOS requires code signing
59-
add_library(${lib} STATIC IMPORTED)
60-
else()
61-
add_library(${lib} SHARED IMPORTED)
62-
endif()
56+
if("${lib}" STREQUAL "extension_module" AND (NOT CMAKE_TOOLCHAIN_IOS))
57+
add_library(${lib} SHARED IMPORTED)
6358
else()
59+
# Building a share library on iOS requires code signing, so it's easier
60+
# to keep all libs as static when CMAKE_TOOLCHAIN_IOS is used
6461
add_library(${lib} STATIC IMPORTED)
6562
endif()
6663
set_target_properties(

0 commit comments

Comments
 (0)