executorch should re-export executorch_core, shouldn't it?

swolchok · swolchok · commit f560b2194f10 · 2025-02-11T19:07:10.000-08:00
suspect this might fix qnn build failures on main ghstack-source-id: ef74e78 ghstack-comment-id: 2652553698 Pull Request resolved: #8404
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -596,7 +596,7 @@ endif()
 # any backends.
 #
 add_library(executorch ${_executorch__srcs})
-target_link_libraries(executorch PRIVATE executorch_core)
+target_link_libraries(executorch PUBLIC executorch_core)
 target_include_directories(executorch PUBLIC ${_common_include_directories})
 target_compile_definitions(executorch PUBLIC C10_USING_CUSTOM_GENERATED_MACROS)
 target_compile_options(executorch PUBLIC ${_common_compile_options})

Original file line number	Diff line number	Diff line change
`@@ -596,7 +596,7 @@ endif()`
`596`	`596`	`# any backends.`
`597`	`597`	`#`
`598`	`598`	`add_library(executorch ${_executorch__srcs})`
`599`		`-target_link_libraries(executorch PRIVATE executorch_core)`
	`599`	`+target_link_libraries(executorch PUBLIC executorch_core)`
`600`	`600`	`target_include_directories(executorch PUBLIC ${_common_include_directories})`
`601`	`601`	`target_compile_definitions(executorch PUBLIC C10_USING_CUSTOM_GENERATED_MACROS)`
`602`	`602`	`target_compile_options(executorch PUBLIC ${_common_compile_options})`