Skip to content

Commit f56fbbc

Browse files
metascroymalfet
authored andcommitted
remove old et setup from misc doc (#418)
* remove old et setup from misc doc * reference executorch setup before ET command
1 parent 4b34158 commit f56fbbc

File tree

2 files changed

+4
-19
lines changed

2 files changed

+4
-19
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,8 @@ This produces a `.so` file, also called a Dynamic Shared Object. This `.so` can
143143

144144
### Exporting for Mobile via ExecuTorch
145145

146+
Before exporting to an ExecuTorch pte file with the command below, you must first [set-up ExecuTorch](docs/executorch_setup.md) inside torchchat.
147+
146148
```
147149
python3 torchchat.py export stories15M --output-pte-path stories15M.pte
148150
```

docs/MISC.md

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -736,26 +736,9 @@ install them from source.
736736
List dependencies for these backends
737737

738738
### Setting up ExecuTorch and runner-et
739-
Set up ExecuTorch by following the instructions [here](https://pytorch.org/executorch/stable/getting-started-setup.html#setting-up-executorch).
740-
For convenience, we provide a script that does this for you.
739+
To set-up ExecuTorch, see the instructions [here](executorch_setup.md).
741740

742-
From the torchchat root directory, run the following
743-
```
744-
export TORCHCHAT_ROOT=${PWD}
745-
./scripts/install_et.sh
746-
```
747-
748-
This will create a build directory, git clone ExecuTorch to ./build/src, applies some patches to the ExecuTorch source code, install the ExecuTorch python libraries with pip, and install the required ExecuTorch C++ libraries to ./build/install. This will take a while to complete.
749-
750-
After ExecuTorch is installed, you can build runner-et from the torchchat root directory with the following
751-
752-
```
753-
export TORCHCHAT_ROOT=${PWD}
754-
cmake -S ./runner-et -B build/cmake-out -G Ninja
755-
cmake --build ./build/cmake-out
756-
```
757-
758-
The built executable is located at ./build/cmake-out/runner-et.
741+
To build and insall the runners, see instructions [here](runner_build.md).
759742

760743
### Tiktoken instructions & instructions for running llama3 without a python environment
761744

0 commit comments

Comments
 (0)