You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
Add an module extension target always built as a static library. This is a hacky workaround to the fact that the llama runner currently relies on some fragile linking behavior and requires consuming the module extension as a static lib. However, the nanogpt_runner needs to consume it as a static lib to avoid duplicate primitive op registration. I'm not 100% clear on why llama runner doesn't hit this yet. Maybe something to do with the primitive op -> executorch -> llama_runner -> llama_main chain having a top level target that doesn't reference the core executorch dependency leading to it not being pulled in at the top level?
Anyway, this new target will be removed once we refactor the CMake build post-alpha. Note that by adding a completely new target, this should cause no regressions and should be safe to land.
Pull Request resolved: #2904
Test Plan:
Internal + external CI.
Built and ran nanogpt_runner on linux and mac linking against extension_module_static.
Reviewed By: mikekgfb
Differential Revision: D55834574
Pulled By: GregoryComer
fbshipit-source-id: 4f340e133b9cdc8ef40f154342b396143d78e84f
0 commit comments