Skip to content

Remove dependency on exir.capture from generate_etrecord. #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vmpuri
Copy link

@vmpuri vmpuri commented Oct 18, 2023

Summary:
exir.capture is deprecated. Update etrecord.bin to align with new serialization schema

Deprecation warning will still trigger at runtime due to executorch.exir.tests.models import.

Differential Revision: D50378335

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for resplendent-gnome-14e531 canceled.

Name Link
🔨 Latest commit 24c83ad
🔍 Latest deploy log https://app.netlify.com/sites/resplendent-gnome-14e531/deploys/6532c501c68659000899444c

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 18, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50378335

vmpuri pushed a commit to vmpuri/executorch-1 that referenced this pull request Oct 19, 2023
Summary:

exir.capture is deprecated. Update etrecord.bin to align with new serialization schema

Deprecation warning will still trigger at runtime due to `executorch.exir.tests.models` import.

Differential Revision: D50378335
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50378335

vmpuri pushed a commit to vmpuri/executorch-1 that referenced this pull request Oct 20, 2023
Summary:

exir.capture is deprecated. Update etrecord.bin to align with new serialization schema

Deprecation warning will still trigger at runtime due to `executorch.exir.tests.models` import.

Differential Revision: D50378335
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50378335

Summary:

exir.capture is deprecated. Update etrecord.bin to align with new serialization schema

Deprecation warning will still trigger at runtime due to `executorch.exir.tests.models` import.

Differential Revision: D50378335
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50378335

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f8c2742.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants