Skip to content

Arm backend: Remove logger.setLevel #10103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Apr 11, 2025

We don't want to set logging levels for separate files. This should be controlled from a top level, e.g. pytest flag or similar.

cc @digantdesai @freddan80 @per @zingo

We don't want to set logging levels for separate files. This should be
controlled from a top level, e.g. pytest flag or similar.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I18d4b205eda0913dc70d8922463c755985c9cbe6
Copy link

pytorch-bot bot commented Apr 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10103

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d5f5983 with merge base bc03171 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Apr 11, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2025
@zingo zingo merged commit a147346 into pytorch:main Apr 11, 2025
168 of 170 checks passed
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
We don't want to set logging levels for separate files. This should be
controlled from a top level, e.g. pytest flag or similar.

Signed-off-by: Oscar Andersson <[email protected]>
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
We don't want to set logging levels for separate files. This should be
controlled from a top level, e.g. pytest flag or similar.

Signed-off-by: Oscar Andersson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants