Arm backend: Add support for TOSA 1.0 serializer #10135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt serialization and TOSA graph handling to be able to handle 1.0. Also install TOSA pip package for 1.0 alongside 0.80. Signed-off-by: Per Åstrand <[email protected]> Change-Id: I1ec5fe5836d1aa2d343048a13a85de522da04386
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10135
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ca242fc with merge base 8e89094 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
added
the
partner: arm
zingo
approved these changes
Apr 14, 2025
digantdesai
reviewed
Apr 17, 2025
Comment on lines
+91
to
+94
| if isinstance(tosa_spec, tosa_specification.Tosa_0_80): | ||
| import tosa_tools.v0_80.serializer.tosa_serializer as ts # type: ignore | ||
| elif isinstance(tosa_spec, tosa_specification.Tosa_1_00): | ||
| import serializer.tosa_serializer as ts # type: ignore |
There was a problem hiding this comment.
IIUC in the future, the serializer will support older versions of TOSA, and we will delete the v0.80 serializer, right? If yes, what is the ETA?
There was a problem hiding this comment.
Yes, the 0.80 should be deleted when 1.0 has landed and is stable.
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
Adapt serialization and TOSA graph handling to be able to handle 1.0. Also install TOSA pip package for 1.0 alongside 0.80. ### Test plan Validate that 0.80 TOSA version test still work with the 1.0 package installed. Signed-off-by: Per Åstrand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt serialization and TOSA graph handling to be able to handle 1.0. Also install TOSA pip package for 1.0 alongside 0.80.
Test plan
Validate that 0.80 TOSA version test still work with the 1.0 package installed.
cc @digantdesai @freddan80 @zingo @oscarandersson8218