Skip to content

Update pytorch-labs/tokenizers to 295ee78 #10161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Update pytorch-labs/tokenizers to 295ee78 #10161

merged 1 commit into from
Apr 15, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Apr 14, 2025

Summary

Update tokenizers lib to include pytorch-labs/tokenizers#46.

Test plan

CI

Copy link

pytorch-bot bot commented Apr 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10161

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d4dc679 with merge base 4ea6839 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 14, 2025
@jathu jathu marked this pull request as ready for review April 14, 2025 21:42
@jackzhxng
Copy link
Contributor

Hmm why is the submodule showing only 4 files changed? My pin update from the commit prior to yours shows a lot more - https://github.com/pytorch/executorch/pull/10017/files

@jathu
Copy link
Contributor Author

jathu commented Apr 15, 2025

@jackzhxng I'm not sure. I just update the submodule to main (it was using a detached commit pytorch-labs/tokenizers@71167bf). How did you update the submodule?

Copy link
Contributor

@jackzhxng jackzhxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mb, should be fine actually after dbl checking the changed files

@jathu jathu merged commit 4b1b4ba into main Apr 15, 2025
82 of 84 checks passed
@jathu jathu deleted the jathu/bump-tokenizers branch April 15, 2025 18:17
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
### Summary

Update tokenizers lib to include
pytorch-labs/tokenizers#46.

### Test plan

CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants