Skip to content

[Android] Use same stats as llm::Stats #10247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

Conversation

kirklandsign
Copy link
Contributor

We can report the full data. Not only tps.

Copy link

pytorch-bot bot commented Apr 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10247

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 7 New Failures, 59 Pending, 4 Unrelated Failures

As of commit e609943 with merge base 6a812a9 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2025
@kirklandsign kirklandsign changed the title Use same as llm:Stats [Android] Use same stats as llm::Stats Apr 16, 2025
@kirklandsign kirklandsign temporarily deployed to upload-benchmark-results April 16, 2025 23:29 — with GitHub Actions Inactive
@kirklandsign kirklandsign added the release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) label Apr 17, 2025
@kirklandsign kirklandsign temporarily deployed to upload-benchmark-results April 17, 2025 05:32 — with GitHub Actions Inactive
@kirklandsign kirklandsign had a problem deploying to upload-benchmark-results April 17, 2025 19:00 — with GitHub Actions Failure
@kirklandsign kirklandsign marked this pull request as ready for review April 17, 2025 19:56
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kirklandsign kirklandsign temporarily deployed to upload-benchmark-results April 17, 2025 20:20 — with GitHub Actions Inactive
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary:
We can report the full data. Not only tps.


Reviewed By: cccclai

Differential Revision: D73207250

Pulled By: kirklandsign
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73207250

@facebook-github-bot facebook-github-bot merged commit d82e852 into main Apr 19, 2025
55 of 91 checks passed
@facebook-github-bot facebook-github-bot deleted the android-llm-stats branch April 19, 2025 00:04
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
Differential Revision: D73207250

Pull Request resolved: pytorch#10247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants