Update module wrapper so that params are explicitly registered to the wrapper #10357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10357
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 9a09392 with merge base 3eac583 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
… wrapper Pull Request resolved: #10305 Seeing issue with linear where the fqns for constants disappear. Registering self.method_name as a submodule of wrapper means that the parameters are registered to the wrapper. thanks @angelayi for the fix! ``` File "/data/users/lfq/fbsource/buck-out/v2/gen/fbcode/1af94fa701700343/executorch/test/models/__export_delegated_program__/export_delegated_program#link-tree/torch/export/_trace.py", line 1980, in _export_for_training export_artifact = export_func( File "/data/users/lfq/fbsource/buck-out/v2/gen/fbcode/1af94fa701700343/executorch/test/models/__export_delegated_program__/export_delegated_program#link-tree/torch/export/_trace.py", line 1473, in _strict_export _replace_param_buffer_names(param_buffer_table, export_graph_signature) File "/data/users/lfq/fbsource/buck-out/v2/gen/fbcode/1af94fa701700343/executorch/test/models/__export_delegated_program__/export_delegated_program#link-tree/torch/export/_trace.py", line 272, in _replace_param_buffer_names spec.target = param_buffer_table[spec.target] KeyError: 'L__self___fn___self___linear.weight' ``` ghstack-source-id: 279346028 @exported-using-ghexport Differential Revision: [D73279618](https://our.internmc.facebook.com/intern/diff/D73279618/)
lucylq
force-pushed
the
gh/lucylq/61/orig
branch
from
58c3cf2 to
9a09392
Compare
kirklandsign
approved these changes
Apr 22, 2025
kirklandsign
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request resolved: #10305
Seeing issue with linear where the fqns for constants disappear.
Registering self.method_name as a submodule of wrapper means that the parameters are registered to the wrapper. thanks @angelayi for the fix!
ghstack-source-id: 279346028
@exported-using-ghexport
Differential Revision: D73279618