Fix uint16 support for quantize_per_tensor. #10398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10398
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9b072dc with merge base 3072890 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73517183 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 23, 2025
Summary: `ET_SWITCH_REALB_TYPES` added in D73268792 does not include UInt16 dtype. This diff adds a switch case instead of ET macros for checking quant min/max. Differential Revision: D73517183
hsharma35
force-pushed
the
export-D73517183
branch
from
baf1a5a to
b4c8600
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73517183 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 23, 2025
Summary: `ET_SWITCH_REALB_TYPES` added in D73268792 does not include UInt16 dtype. This diff adds a switch case instead of ET macros for checking quant min/max. Differential Revision: D73517183
hsharma35
force-pushed
the
export-D73517183
branch
from
b4c8600 to
a75d980
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73517183 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 23, 2025
Summary: `ET_SWITCH_REALB_TYPES` added in D73268792 does not include UInt16 dtype. This diff adds a switch case instead of ET macros for checking quant min/max. Differential Revision: D73517183
hsharma35
force-pushed
the
export-D73517183
branch
from
a75d980 to
9ef7ef8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73517183 |
Summary: `ET_SWITCH_REALB_TYPES` added in D73268792 does not include UInt16 dtype. This diff adds a switch case instead of ET macros for checking quant min/max. Reviewed By: zonglinpeng Differential Revision: D73517183
hsharma35
force-pushed
the
export-D73517183
branch
from
9ef7ef8 to
9b072dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73517183 |
mcremon-meta
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ET_SWITCH_REALB_TYPESadded in D73268792 does not include UInt16 dtype. This diff adds a switch case instead of ET macros for checking quant min/max.Differential Revision: D73517183