Skip to content

Add test for floor divide. #10483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

hsharma35
Copy link
Contributor

Summary: Hifi div_out_mode with mode="floor" returns incorrect results. This diff adds a test to reproduce the failure.

Differential Revision: D73675567

@hsharma35 hsharma35 requested a review from tarun292 as a code owner April 25, 2025 17:39
Copy link

pytorch-bot bot commented Apr 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10483

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit e8900ce with merge base 9cc9f82 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73675567

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Apr 25, 2025
Summary:

Hifi div_out_mode with mode="floor" returns incorrect results. This diff adds a test to reproduce the failure.

Differential Revision: D73675567
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73675567

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Apr 25, 2025
Summary:

Hifi div_out_mode with mode="floor" returns incorrect results. This diff adds a test to reproduce the failure.

Differential Revision: D73675567
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73675567

@hsharma35 hsharma35 requested a review from Vysarat April 25, 2025 18:49
hsharma35 added a commit to hsharma35/executorch that referenced this pull request Apr 26, 2025
Summary:

Hifi div_out_mode with mode="floor" returns incorrect results. This diff adds a test to reproduce the failure.

Reviewed By: mcremon-meta

Differential Revision: D73675567
Summary:
Pull Request resolved: pytorch#10483

Hifi div_out_mode with mode="floor" returns incorrect results. This diff adds a test to reproduce the failure.

Reviewed By: mcremon-meta

Differential Revision: D73675567
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73675567

@facebook-github-bot facebook-github-bot merged commit df75088 into pytorch:main Apr 27, 2025
83 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants