Update portable op names to match functions.yaml #1049
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50425923 |
|
This pull request was exported from Phabricator. Differential Revision: D50425923 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Oct 20, 2023
Summary: Pull Request resolved: pytorch#1049 - selected_op.yaml; contains *op_names* collected from the model - dtype selective build; for each *op_name*, generate kernel code only if the dtype is used in the model - this diff: make sure op_names in op_<op>.cpp file match the op name collected by selected_op.yaml. This is the op name from [functions.yaml](https://fburl.com/code/uok7njmb) Note: the op names are not used for anything besides selective build, so this change should not break anything. Reviewed By: manuelcandales Differential Revision: D50425923 fbshipit-source-id: 34e7966cc1ef19d98895d87ae82b1be6cbac2090
lucylq
force-pushed
the
export-D50425923
branch
from
ef96af6 to
4c7f603
Compare
Summary: Pull Request resolved: pytorch#1049 - selected_op.yaml; contains *op_names* collected from the model - dtype selective build; for each *op_name*, generate kernel code only if the dtype is used in the model - this diff: make sure op_names in op_<op>.cpp file match the op name collected by selected_op.yaml. This is the op name from [functions.yaml](https://fburl.com/code/uok7njmb) Note: the op names are not used for anything besides selective build, so this change should not break anything. Reviewed By: manuelcandales Differential Revision: D50425923 fbshipit-source-id: 753a2795ba6224fa50310702905da6441aa69b1a
|
This pull request was exported from Phabricator. Differential Revision: D50425923 |
lucylq
force-pushed
the
export-D50425923
branch
from
4c7f603 to
6f4df08
Compare
|
This pull request has been merged in 8f446e3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
selected_op.yaml; contains op_names collected from the model
dtype selective build; for each op_name, generate kernel code only if the dtype is used in the model
this diff: make sure op_names in op_.cpp file match the op name collected by selected_op.yaml. This is the op name from functions.yaml
Note: the op names are not used for anything besides selective build, so this change should not break anything.
Reviewed By: manuelcandales
Differential Revision: D50425923