[ET-VK][ez] Improvements to GLSL codegen script #10605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes Fixed a bug in the caching mechanism in the `gen_vulkan_spv.py` script where changing the YAML file will not trigger a recompile. Allow the python codegen to be applied to files other than GLSL compute shaders. One example application of this is generating header files (`.glslh` files) which can be shared among multiple `.glsl` files. This enables better code re-use and organization. For a simple application of this, see the `reference_matmul_common.glslh` file that was added to the test compute shader library. Differential Revision: [D74008572](https://our.internmc.facebook.com/intern/diff/D74008572/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10605
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 276d882 with merge base cd3b53d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
added a commit
that referenced
this pull request
May 1, 2025
## Changes Fixed a bug in the caching mechanism in the `gen_vulkan_spv.py` script where changing the YAML file will not trigger a recompile. Allow the python codegen to be applied to files other than GLSL compute shaders. One example application of this is generating header files (`.glslh` files) which can be shared among multiple `.glsl` files. This enables better code re-use and organization. For a simple application of this, see the `reference_matmul_common.glslh` file that was added to the test compute shader library. Differential Revision: [D74008572](https://our.internmc.facebook.com/intern/diff/D74008572/) ghstack-source-id: 281448039 Pull Request resolved: #10605
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74008572 |
## Changes Fixed a bug in the caching mechanism in the `gen_vulkan_spv.py` script where changing the YAML file will not trigger a recompile. Allow the python codegen to be applied to files other than GLSL compute shaders. One example application of this is generating header files (`.glslh` files) which can be shared among multiple `.glsl` files. This enables better code re-use and organization. For a simple application of this, see the `reference_matmul_common.glslh` file that was added to the test compute shader library. Differential Revision: [D74008572](https://our.internmc.facebook.com/intern/diff/D74008572/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
May 1, 2025
Pull Request resolved: #10605 ## Changes Fixed a bug in the caching mechanism in the `gen_vulkan_spv.py` script where changing the YAML file will not trigger a recompile. Allow the python codegen to be applied to files other than GLSL compute shaders. One example application of this is generating header files (`.glslh` files) which can be shared among multiple `.glsl` files. This enables better code re-use and organization. For a simple application of this, see the `reference_matmul_common.glslh` file that was added to the test compute shader library. ghstack-source-id: 281449549 @exported-using-ghexport Differential Revision: [D74008572](https://our.internmc.facebook.com/intern/diff/D74008572/)
|
This pull request was exported from Phabricator. Differential Revision: D74008572 |
## Changes Fixed a bug in the caching mechanism in the `gen_vulkan_spv.py` script where changing the YAML file will not trigger a recompile. Allow the python codegen to be applied to files other than GLSL compute shaders. One example application of this is generating header files (`.glslh` files) which can be shared among multiple `.glsl` files. This enables better code re-use and organization. For a simple application of this, see the `reference_matmul_common.glslh` file that was added to the test compute shader library. Differential Revision: [D74008572](https://our.internmc.facebook.com/intern/diff/D74008572/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
May 5, 2025
Pull Request resolved: #10605 ## Changes Fixed a bug in the caching mechanism in the `gen_vulkan_spv.py` script where changing the YAML file will not trigger a recompile. Allow the python codegen to be applied to files other than GLSL compute shaders. One example application of this is generating header files (`.glslh` files) which can be shared among multiple `.glsl` files. This enables better code re-use and organization. For a simple application of this, see the `reference_matmul_common.glslh` file that was added to the test compute shader library. ghstack-source-id: 282026609 @exported-using-ghexport Differential Revision: [D74008572](https://our.internmc.facebook.com/intern/diff/D74008572/)
|
This pull request was exported from Phabricator. Differential Revision: D74008572 |
jorgep31415
approved these changes
May 5, 2025
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Changes
Fixed a bug in the caching mechanism in the
gen_vulkan_spv.pyscript where changing the YAML file will not trigger a recompile.Allow the python codegen to be applied to files other than GLSL compute shaders. One example application of this is generating header files (
.glslhfiles) which can be shared among multiple.glslfiles. This enables better code re-use and organization.For a simple application of this, see the
reference_matmul_common.glslhfile that was added to the test compute shader library.Differential Revision: D74008572