Avoid directly calling the map operator #10638
Conversation
ydwu4
requested review from
JacobSzwejbka,
tarun292 and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10638
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6f4cfd9 with merge base 385d860 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74036464 |
|
@pytorchbot label "topic: not user facing" |
Summary: Calling the higher order operator directly is not recommended since it skips the safety check. Reviewed By: angelayi Differential Revision: D74036464
|
This pull request was exported from Phabricator. Differential Revision: D74036464 |
|
is this true for cond? I should stop pointing people to torch.cond and instead to torch_cond and similar for all control flow ops? |
|
torch.cond is the recommended way and there isn't a torch_cond. map haven't been exposed to top-level (we have a follow up stack to fix its issues). I import the user-facing function as torch_map to avoid name collisions with python built-in map. |
Differential Revision: D74036464 Pull Request resolved: pytorch#10638
Summary: Calling the higher order operator directly is not recommended since it skips the safety check.
Differential Revision: D74036464