Skip to content

Permute elimination pass fixes. #10662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025

Conversation

abeakkas
Copy link
Contributor

@abeakkas abeakkas commented May 2, 2025

Summary:

  • Generalize the logic to handle any permutation.
  • Handle args/kwargs/defaults properly.
  • Simplify and generalize graph traversal algorithm.
  • Fix incorrect view/permute fusion.
  • Add support for permuting slice_copy.

Reviewed By: hsharma35

Differential Revision: D74011447

Summary:
- Generalize the logic to handle any permutation.
- Handle args/kwargs/defaults properly.
- Simplify and generalize graph traversal algorithm.
- Fix incorrect view/permute fusion.
- Add support for permuting slice_copy.

Reviewed By: hsharma35

Differential Revision: D74011447
@abeakkas abeakkas requested a review from tarun292 as a code owner May 2, 2025 19:59
Copy link

pytorch-bot bot commented May 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10662

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 1a21bba with merge base 4cc6532 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74011447

@abeakkas
Copy link
Contributor Author

abeakkas commented May 2, 2025

@pytorchbot label "topic: not user facing"

@facebook-github-bot facebook-github-bot merged commit f203c94 into pytorch:main May 3, 2025
5 of 10 checks passed
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
Differential Revision: D74011447

Pull Request resolved: pytorch#10662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants