[ET-VK] Simplifying conv1d op shader by changing it to process one output texel per thread. #10690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10690
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
force-pushed
the
gh/trivedivivek/81/orig
branch
from
ab09362 to
bb9ec6d
Compare
kirklandsign
approved these changes
May 5, 2025
…tput texel per thread. Pull Request resolved: #10665 This diff changes conv1d shader to process one output texel per thread, increasing GPU occupancy and improve performance. ghstack-source-id: 282024192 Differential Revision: [D74097560](https://our.internmc.facebook.com/intern/diff/D74097560/)
kirklandsign
force-pushed
the
gh/trivedivivek/82/orig
branch
from
18e0be3 to
39f6bd9
Compare
phaiting
pushed a commit
that referenced
this pull request
May 6, 2025
…tput texel per thread. (#10690) Pull Request resolved: #10665 This diff changes conv1d shader to process one output texel per thread, increasing GPU occupancy and improve performance. ghstack-source-id: 282024192 Differential Revision: [D74097560](https://our.internmc.facebook.com/intern/diff/D74097560/)
jhelsby
pushed a commit
to jhelsby/executorch
that referenced
this pull request
May 9, 2025
…tput texel per thread. (pytorch#10690) Pull Request resolved: pytorch#10665 This diff changes conv1d shader to process one output texel per thread, increasing GPU occupancy and improve performance. ghstack-source-id: 282024192 Differential Revision: [D74097560](https://our.internmc.facebook.com/intern/diff/D74097560/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #10665 by @trivedivivek
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/82/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/82/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/81/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/82/orig
@diff-train-skip-merge