Arm backend: Add non-interactive in git hook #10712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10712
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 1 Unrelated FailureAs of commit ab8b531 with merge base f4875cc ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
perheld
added
partner: arm
The pre-push script is a nice to have script as a git hook for your work with the arm backend. In fact, it is so nice that we would like it to be part of CI jobs but to make that happen it needs to be non-interactive. This patch adds support for launching the script and never ending up in a scenario where the user has to interact with it. Signed-off-by: [email protected] Change-Id: I345a3a71f1b81446228150baf4db28bf4a47b0f1
perheld
force-pushed
the
upstream/ph-git-pre-push-non-interactive
branch
from
724bc65 to
ab8b531
Compare
facebook-github-bot
added
the
CLA Signed
|
llama error unrelated |
zingo
approved these changes
May 6, 2025
phaiting
pushed a commit
that referenced
this pull request
May 6, 2025
The pre-push script is a nice to have script as a git hook for your work with the arm backend. In fact, it is so nice that we would like it to be part of CI jobs but to make that happen it needs to be non-interactive. This patch adds support for launching the script and never ending up in a scenario where the user has to interact with it. Signed-off-by: [email protected]
jhelsby
pushed a commit
to jhelsby/executorch
that referenced
this pull request
May 9, 2025
The pre-push script is a nice to have script as a git hook for your work with the arm backend. In fact, it is so nice that we would like it to be part of CI jobs but to make that happen it needs to be non-interactive. This patch adds support for launching the script and never ending up in a scenario where the user has to interact with it. Signed-off-by: [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-push script is a nice to have script as a git hook for your work with the arm backend.
In fact, it is so nice that we would like it to be part of CI jobs but to make that happen it needs to be non-interactive.
This patch adds support for launching the script and never ending up in a scenario where the user has to interact with it.
Signed-off-by: [email protected]
Change-Id: I345a3a71f1b81446228150baf4db28bf4a47b0f1
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218