Skip to content

Arm backend: Create op utility function for num input verification #10713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

Sebastian-Larsson
Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson commented May 6, 2025

Create function for validating that the number of inputs is correct in each node visitor.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Create function for validating that the number of inputs is correct in
each node visitor.

Signed-off-by: Sebastian Larsson <[email protected]>
Change-Id: I6bb17807bbcadbc66ba573964e789ac971071ef8
@Sebastian-Larsson Sebastian-Larsson added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels May 6, 2025
Copy link

pytorch-bot bot commented May 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10713

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit b9166b7 with merge base 5e5cea8 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2025
@Sebastian-Larsson
Copy link
Collaborator Author

Failing CI seems unrelated

@zingo
Copy link
Collaborator

zingo commented May 6, 2025

MacOS fails unrelated

@zingo zingo merged commit 14586f9 into pytorch:main May 6, 2025
173 of 174 checks passed
phaiting pushed a commit that referenced this pull request May 6, 2025
…10713)

Create function for validating that the number of inputs is correct in
each node visitor.

Signed-off-by: Sebastian Larsson <[email protected]>
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
…ytorch#10713)

Create function for validating that the number of inputs is correct in
each node visitor.

Signed-off-by: Sebastian Larsson <[email protected]>
@Sebastian-Larsson Sebastian-Larsson deleted the num_input_validation branch May 15, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants