Clarify that the python example isn't exactly the same #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When reading this, "perform the same action" made it sound like these steps would also create an `add.pte` file, but that's not true. I looked into adding the code that would actually perform the exact same action, but the AddModule isn't in exir.tests. So, instead just call out that it's not literally the same action. While I'm here: - Remove the `>>>` so that users can copy and paste all of the lines at once - Remove the `print`, which just printed something like `<executorch.exir.program._program.ExirExportedProgram object at 0x102f1ae00>` Differential Revision: D50578857
✅ Deploy Preview for resplendent-gnome-14e531 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50578857 |
|
This pull request has been merged in d8e9b26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When reading this, "perform the same action" made it sound like these steps would also create an
add.ptefile, but that's not true.I looked into adding the code that would actually perform the exact same action, but the AddModule isn't in exir.tests. So, instead just call out that it's not literally the same action.
While I'm here:
>>>so that users can copy and paste all of the lines at onceprint, which just printed something like<executorch.exir.program._program.ExirExportedProgram object at 0x102f1ae00>Differential Revision: D50578857