Skip to content

Move OPTIMIZE_SIZE to default preset #10802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Move OPTIMIZE_SIZE to default preset #10802

merged 1 commit into from
May 13, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 10, 2025

Summary

TSIA

Test plan

$ cmake --preset macos-arm64 && cmake --build cmake-out --parallel
$ test/build_size_test.sh

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries topic: not user facing labels May 10, 2025
Copy link

pytorch-bot bot commented May 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10802

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 6 Pending

As of commit 70387e5 with merge base 4a738bd (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 10, 2025
@jathu jathu force-pushed the jathu/move-EXECUTORCH_ENABLE_EVENT_TRACER branch from 6daeedc to 8c113c5 Compare May 12, 2025 16:39
@jathu jathu force-pushed the jathu/move-OPTIMIZE_SIZE branch from 5202dad to 3af82b7 Compare May 12, 2025 16:42
@jathu jathu marked this pull request as ready for review May 12, 2025 16:52
@jathu jathu force-pushed the jathu/move-EXECUTORCH_ENABLE_EVENT_TRACER branch from 8c113c5 to daa4e4a Compare May 12, 2025 21:00
@jathu jathu requested review from digantdesai and mcr229 as code owners May 12, 2025 21:00
@jathu jathu force-pushed the jathu/move-OPTIMIZE_SIZE branch from 3af82b7 to fb15c25 Compare May 12, 2025 21:01
@jathu jathu force-pushed the jathu/move-EXECUTORCH_ENABLE_EVENT_TRACER branch from daa4e4a to c2c9a6b Compare May 12, 2025 21:50
@jathu jathu force-pushed the jathu/move-OPTIMIZE_SIZE branch from fb15c25 to 3abc792 Compare May 12, 2025 21:51
Base automatically changed from jathu/move-EXECUTORCH_ENABLE_EVENT_TRACER to main May 12, 2025 23:14
@jathu jathu force-pushed the jathu/move-OPTIMIZE_SIZE branch from 3abc792 to 70387e5 Compare May 12, 2025 23:16
@jathu jathu added release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. and removed topic: not user facing labels May 12, 2025
@jathu jathu merged commit 2ee2e03 into main May 13, 2025
194 of 198 checks passed
@jathu jathu deleted the jathu/move-OPTIMIZE_SIZE branch May 13, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants