[ET-VK] Removing un used push constants for conv2d pw. #10814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes unused push constants from conv2d pw op to reduce memory usage. Differential Revision: [D74523769](https://our.internmc.facebook.com/intern/diff/D74523769/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
May 12, 2025
This change removes unused push constants from conv2d pw op to reduce memory usage. Differential Revision: [D74523769](https://our.internmc.facebook.com/intern/diff/D74523769/) ghstack-source-id: 283411414 Pull Request resolved: #10814
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10814
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit c5ca7ec with merge base d966a47 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74523769 |
jorgep31415
approved these changes
May 12, 2025
This change removes unused push constants from conv2d pw op to reduce memory usage. Differential Revision: [D74523769](https://our.internmc.facebook.com/intern/diff/D74523769/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
May 12, 2025
Pull Request resolved: #10814 This change removes unused push constants from conv2d pw op to reduce memory usage. ghstack-source-id: 283445063 @exported-using-ghexport Differential Revision: [D74523769](https://our.internmc.facebook.com/intern/diff/D74523769/)
|
This pull request was exported from Phabricator. Differential Revision: D74523769 |
This change removes unused push constants from conv2d pw op to reduce memory usage. Differential Revision: [D74523769](https://our.internmc.facebook.com/intern/diff/D74523769/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
May 12, 2025
Pull Request resolved: #10814 This change removes unused push constants from conv2d pw op to reduce memory usage. ghstack-source-id: 283452641 @exported-using-ghexport Differential Revision: [D74523769](https://our.internmc.facebook.com/intern/diff/D74523769/)
|
This pull request was exported from Phabricator. Differential Revision: D74523769 |
This change removes unused push constants from conv2d pw op to reduce memory usage. Differential Revision: [D74523769](https://our.internmc.facebook.com/intern/diff/D74523769/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
May 13, 2025
Pull Request resolved: #10814 This change removes unused push constants from conv2d pw op to reduce memory usage. ghstack-source-id: 283597017 @exported-using-ghexport Differential Revision: [D74523769](https://our.internmc.facebook.com/intern/diff/D74523769/)
|
This pull request was exported from Phabricator. Differential Revision: D74523769 |
facebook-github-bot
merged commit d8e84e2
into
gh/trivedivivek/87/base
85 of 88 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
May 13, 2025
Pull Request resolved: #10814 This change removes unused push constants from conv2d pw op to reduce memory usage. ghstack-source-id: 283597017 @exported-using-ghexport Differential Revision: [D74523769](https://our.internmc.facebook.com/intern/diff/D74523769/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This change removes unused push constants from conv2d pw op to reduce memory usage.
Differential Revision: D74523769