Skip to content

Arm backend: Add validation for same dtype to operators #10872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

Sebastian-Larsson
Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson commented May 14, 2025

When applicable, check that the data types of inputs to a given operator are the same.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@Sebastian-Larsson Sebastian-Larsson added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels May 14, 2025
Copy link

pytorch-bot bot commented May 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10872

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 2 Pending, 1 Unrelated Failure

As of commit 00d8784 with merge base c913634 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2025
@zingo zingo added the release notes: none Do not include this in the release notes label May 14, 2025
When applicable, check that the data types of inputs to a given operator
are the same.

Change-Id: I94edea9433413e4adb49edbd93e247596e0cd0b7
Signed-off-by: Sebastian Larsson <[email protected]>
@zingo zingo force-pushed the validate_same_dtype branch from 3d800f4 to aacee59 Compare May 15, 2025 04:39
@zingo
Copy link
Collaborator

zingo commented May 15, 2025

lintrunner llama and llava fails unrelated,

@zingo zingo merged commit 5222489 into pytorch:main May 15, 2025
179 of 182 checks passed
@Sebastian-Larsson Sebastian-Larsson deleted the validate_same_dtype branch May 15, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants