Move optimized target definitions to op_registration.bzl #10877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
^ So we can pull these definitions into codegen.bzl (we can't pull in targets.bzl files). Differential Revision: [D74741846](https://our.internmc.facebook.com/intern/diff/D74741846/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10877
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 9f9181f with merge base 9663bfb ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74741846 |
^ So we can pull these definitions into codegen.bzl (we can't pull in targets.bzl files). Differential Revision: [D74741846](https://our.internmc.facebook.com/intern/diff/D74741846/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D74741846 |
iseeyuan
approved these changes
May 14, 2025
^ So we can pull these definitions into codegen.bzl (we can't pull in targets.bzl files). Differential Revision: [D74741846](https://our.internmc.facebook.com/intern/diff/D74741846/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
May 14, 2025
Pull Request resolved: #10877 So we can use them in codegen.bzl later (can't pull in definitions from targets.bzl files). ghstack-source-id: 284040542 Differential Revision: [D74741846](https://our.internmc.facebook.com/intern/diff/D74741846/)
|
This pull request was exported from Phabricator. Differential Revision: D74741846 |
^ So we can pull these definitions into codegen.bzl (we can't pull in targets.bzl files). Differential Revision: [D74741846](https://our.internmc.facebook.com/intern/diff/D74741846/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D74741846 |
^ So we can pull these definitions into codegen.bzl (we can't pull in targets.bzl files). Differential Revision: [D74741846](https://our.internmc.facebook.com/intern/diff/D74741846/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D74741846 |
facebook-github-bot
merged commit a4d70f7
into
gh/lucylq/75/base
90 of 91 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
This was referenced May 19, 2025
kirklandsign
pushed a commit
that referenced
this pull request
May 20, 2025
Pull Request resolved: #10877 So we can use them in codegen.bzl later (can't pull in definitions from targets.bzl files). ghstack-source-id: 284862879 Differential Revision: [D74741846](https://our.internmc.facebook.com/intern/diff/D74741846/)
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#10877 So we can use them in codegen.bzl later (can't pull in definitions from targets.bzl files). ghstack-source-id: 284862879 Differential Revision: [D74741846](https://our.internmc.facebook.com/intern/diff/D74741846/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
^
So we can pull these definitions into codegen.bzl (we can't pull in targets.bzl files).
Differential Revision: D74741846